Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improved alias resolvers (#1181) #1189

Merged
merged 1 commit into from
Aug 2, 2024
Merged

feat: improved alias resolvers (#1181) #1189

merged 1 commit into from
Aug 2, 2024

Conversation

dacevedo12
Copy link
Contributor

  • added support for resolving trivial nested fields

Closes #1181

@dacevedo12
Copy link
Contributor Author

There seems to be a flaky unrelated test

@DamianCzajkowski
Copy link
Contributor

Hi @dacevedo12 those failing tests are fixed on the main, try to merge it and it should be fine :D

@dacevedo12
Copy link
Contributor Author

Indeed, thanks. CI is now green

@DamianCzajkowski
Copy link
Contributor

LGTM! Please add a changelog entry, and I'll merge it. :D

@dacevedo12
feat: improved alias resolvers (mirumee#1181)
286dbf3 
- added support for resolving trivial nested fields
@dacevedo12
Copy link
Contributor Author

Changelog entry added 🚀

@DamianCzajkowski DamianCzajkowski merged commit 7dffde4 into mirumee:main Aug 2, 2024
20 checks passed
@rafalp rafalp added this to the Next release milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianCzajkowski DamianCzajkowski DamianCzajkowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next release
Development

Successfully merging this pull request may close these issues.

set_alias support for nested attributes
3 participants
@dacevedo12 @DamianCzajkowski @rafalp